SerialVersionUIDInSerializableClass - Update the error location #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
changed the title
Error will be highlighted only at class location when `serialVersionUID` is missing. In case of wrong type, or modifier of `serialVersionUID` error will be highlighted at property declaration Add TC asserting location and error msg Add TC for nested classes
atulgpt
force-pushed
the
fixes/6109/highlight-actionable-area
branch
from
cc494e7
to
b6ca359
Compare
cortinico
reviewed
May 20, 2023
...c/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/SerialVersionUIDInSerializableClass.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #6114 +/- ##
============================================
+ Coverage 84.86% 84.89% +0.03%
- Complexity 4011 4022 +11
============================================
Files 568 569 +1
Lines 13422 13449 +27
Branches 2368 2371 +3
============================================
+ Hits 11390 11418 +28
Misses 871 871
+ Partials 1161 1160 -1
|
cortinico
approved these changes
May 20, 2023
antonis
added a commit
to wordpress-mobile/WordPress-Android
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6109
The error will be highlighted only at the class location when
serialVersionUIDis missing.In case of the wrong type, or modifier of
serialVersionUIDerror will be highlighted at property declaration Add TC asserting location and error msgAdd TC for nested classes