Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.19.5 introduced error for python 3.8 #753

Closed
adi- opened this issue Aug 13, 2024 · 3 comments
Closed

v0.19.5 introduced error for python 3.8 #753

adi- opened this issue Aug 13, 2024 · 3 comments

Comments

@adi-
Copy link

adi- commented Aug 13, 2024

v0.19.4...v0.19.5 introduced following error (python 3.8.10):

File "/home/vagrant/.venv/lib/python3.8/site-packages/modeltranslation/_typing.py", line 19, in <module>
    _ListOrTuple: TypeAlias = Union[list[_K], tuple[_K, ...]]
TypeError: 'type' object is not subscriptable
@last-partizan
Copy link
Collaborator

last-partizan commented Aug 13, 2024

Hello.

I fixed this error in master, but please, pin your dependencies to 0.19.2 as we no longer test against 3.8.

@adi-
Copy link
Author

adi- commented Aug 13, 2024

Yes, I did, but wanted to inform you :)

Thank for the fix. Waiting for publication!

@last-partizan
Copy link
Collaborator

This will be published along with other changes sometimes in the future, but it's better for you to pin dependency to 0.19.2.

There's no downside to this, we haven't added any great features, so you aren't missing anything :)

You should upgrade to latest version only after switching to at least python 3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants