Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5 support? #719

Closed
Mapiarz opened this issue Feb 8, 2024 · 10 comments
Closed

Django 5 support? #719

Mapiarz opened this issue Feb 8, 2024 · 10 comments

Comments

@Mapiarz
Copy link

Mapiarz commented Feb 8, 2024

Is Django 5.0 supported, officially or not? Anybody tried it?

@last-partizan
Copy link
Collaborator

Haven't tried personally, but it should work.

If you interested - you can fork the repo, see if test suite passes on django 5, and make a PR enabling it in the pipeline. (Maybe fixing some bugs along the way)

@last-partizan
Copy link
Collaborator

I tried it, and it does not work.

@koleror
Copy link
Contributor

koleror commented Apr 24, 2024

Why do you say it doesn't work? I personnally use it with django 5.0.3 and it works just fine

@philitell
Copy link

I tested it with Django 5.0.4 and Django-Restframework 3.15.1 --> package works perfectly

Thanks for this great project!!!

@last-partizan
Copy link
Collaborator

Why do you say it doesn't work? I personnally use it with django 5.0.3 and it works just fine

Test suite was not passing. If it works in general, it's great news. But please be aware - you can still catch some bugs, until we add django-5.0 to our test matrix and all checks are passed.

@last-partizan
Copy link
Collaborator

Now we're testing against django 5.0, and it works.

@ateuber
Copy link

ateuber commented Aug 19, 2024

Unfortunately it is not working with Django 5.1

  File "/usr/local/lib/python3.11/site-packages/modeltranslation/fields.py", line 221, in __init__
    elif self.remote_field and not self.remote_field.is_hidden():
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'ManyToOneRel' object has no attribute 'is_hidden'. Did you mean: 'hidden'?

last-partizan added a commit that referenced this issue Aug 20, 2024
last-partizan added a commit that referenced this issue Aug 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Refs #719
@last-partizan
Copy link
Collaborator

last-partizan commented Aug 20, 2024

Tried to fix this in #756, but it's slightly more complicated than that.

You can investigate why tests are failing in django-5.1 branch and create PR targeting that branch with fixes. Or i will look into this when i have more time.

@last-partizan
Copy link
Collaborator

@ateuber Please, check if your project works with django-5.1 branch.

If everything is okay, I'll merge it in somewhere next week.

@ateuber
Copy link

ateuber commented Nov 11, 2024

@last-partizan The error is gone, thank you! 👍

last-partizan added a commit that referenced this issue Nov 11, 2024
Refs #719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants