Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle: fix comparison of the prefix version range #7975

Merged

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Sep 5, 2023

Fixes #3759

This change causes the + to always compare higher than any version in the semver position. That means when the dependency specifies 4.+ with no lockfile, it won't attempt to update to version 4.11 because 4.+ already covers that.

The code in gradle/version.rb is particularly challenging. If there's a better way to write this let me know.

@jakecoffman jakecoffman requested a review from a team as a code owner September 5, 2023 18:57
@github-actions github-actions bot added the L: java:gradle Maven packages via Gradle label Sep 5, 2023
@jakecoffman jakecoffman merged commit 68a2f5e into main Sep 5, 2023
@jakecoffman jakecoffman deleted the jakecoffman/gradle-handle-plus-version-comparison branch September 5, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: java:gradle Maven packages via Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot errors on gradle dependency with prefix version range
2 participants