Gradle: fix comparison of the prefix version range #7975
Merged
+29
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3759
This change causes the
+
to always compare higher than any version in the semver position. That means when the dependency specifies4.+
with no lockfile, it won't attempt to update to version 4.11 because 4.+ already covers that.The code in
gradle/version.rb
is particularly challenging. If there's a better way to write this let me know.