Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot go to npm dependency definition #1001

Open
marvinhagemeister opened this issue Dec 8, 2023 · 2 comments
Open

Cannot go to npm dependency definition #1001

marvinhagemeister opened this issue Dec 8, 2023 · 2 comments

Comments

@marvinhagemeister
Copy link
Contributor

Describe the bug

cmd+click (or ctrl+click on windows) doesn't seem to work on npm specifier paths.

To Reproduce

  1. Create deno.json with these contents:
{
  "imports": {
    "svelte": "npm:svelte@4.2.8",
    "svelte/": "npm:/svelte@4.2.8/"
  }
}
  1. Create foo.ts with these contents:
import * as sv from "svelte/internal";
console.log(sv);
  1. Run deno run -A foo.ts
  2. Open foo.ts in vscode and try to click on the svelte/internal import specifier.

Expected behavior

cmd+click (or ctrl+click on windows) should go to the source definition.

Screenshots

lsp-resolve-npm.mp4

Versions

vscode: insiders from 2023-12-05 deno: 1.38.5 extension: v3.28.0

@darkship
Copy link

There seems to be a slight improvement, I can go to the module but definition from imported files inside of the module can't be reached.

deno-lsp-bug-2024-05-19_14.18.13.mp4

vscode: 1.89.1
extention: 3.37.1
deno 1.43.4 (release, x86_64-unknown-linux-gnu)
v8 12.4.254.13
typescript 5.4.5

@darkship
Copy link

@marvinhagemeister I upgraded to deno 1.43.6, now it works \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants