Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Distroless and Alpine image improvements. #324

Open
dojyorin opened this issue Nov 30, 2023 · 3 comments
Open

Proposal: Distroless and Alpine image improvements. #324

dojyorin opened this issue Nov 30, 2023 · 3 comments

Comments

@dojyorin
Copy link

I think there are some issues with Dockerfiles in this repository (especially Alpine and Distroless).

And I came up with some solutions and published in my repository and DockerHub.

Quote from my repository:

This project was created to solve the problems faced by deno_docker official images.

  • tini is redundant
  • Alpine dependent on third-party image
  • Using old debian in Distroless (Uses 11, latest is 12)
  • For tini, explicitly told to use tini which integrated in Docker, and removed it from Dockerfile.
  • For Alpine, resolve dependencies by copy glibc from Distroless.

If my approach is of positive to everyone, I would like to contribute to this repository.

But since I'm beginner, I'd like to hear everyone's opinions first.

@guillaume86
Copy link

About removing tini, on one hand it makes a cleaner Dockerfile/image, but OTOH all your users have to remember to use --init and it's one more barrier to a smooth experience, and removing it now would be a breaking change IMO.
Having up to date alpine images would be great though :).

@Guillaume-Mayer
Copy link

Not sure if it helps, but this works for me:

FROM denoland/deno
WORKDIR /app
ADD . /app
RUN deno compile --allow-net server.ts

FROM gcr.io/distroless/cc-debian12:nonroot
COPY --from=0 /app/server /home/nonroot/server
ENTRYPOINT ["./server"]

@mmastrac
Copy link
Contributor

mmastrac commented Feb 8, 2024

@dojyorin If you would like to PR support for using alpine:latest with glibc from distroless and the existing tini setup, I think that would be a PR we could accept.

Removing tini would be a different discussion, but our Alpine support could definitely be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants