Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine 3.15? #197

Open
danopia opened this issue Jan 10, 2022 · 5 comments
Open

Alpine 3.15? #197

danopia opened this issue Jan 10, 2022 · 5 comments

Comments

@danopia
Copy link

danopia commented Jan 10, 2022

I see that this alpine image is based on Alpine 3.13, which is two versions behind.

What's the attitude for upgrading? Should it be bundled into the next Deno minor version, or just done now on a patch, or should the two bases be available in parallel for a bit (-alpine3.13, -alpine3.15)?

There are already 3.15 images available from the glibc base: https://hub.docker.com/r/frolvlad/alpine-glibc/tags?page=1&name=3.15

@hayd
Copy link
Contributor

hayd commented Jan 10, 2022

Personally I think updating to the latest is fine/not worth having parallel/a complex matrix.

@wperron
Copy link
Contributor

wperron commented Jan 10, 2022

For reference I pinned the version of Alpine to 3.13 a few months ago because version 3.14 had a known issue with Make that crashed the build.

@danopia
Copy link
Author

danopia commented Jan 10, 2022

Ah yeah, there was a docker incompatibility introduced in 3.14, I saw it from a Ruby program back then. So a newer image should probably coincide with a minor release with a 'partially incompatible with docker x.y.z or earlier' footnote.

I only saw this issue myself on CircleCI and they have been running an upgraded docker for months now, long enough for it to escape my memory :)

@bartlomieju
Copy link
Member

PR are welcome to upgrade Alpine image.

@hayd
Copy link
Contributor

hayd commented Jan 18, 2022

The one line change seems to build

-FROM frolvlad/alpine-glibc:alpine-3.13
+FROM frolvlad/alpine-glibc:alpine-3.15

but I've no idea if #152 (cc @mitranim) is still relevant.... It seems like the make issue is fixed with updating docker client? (For me the failing make example actually works on 3.14 🤷 .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants