Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): support task object notation for tasks request #27076

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Nov 26, 2024

Fixes denoland/vscode_deno#1211. Requires client-side change as well so 'Open task definition' works: denoland/vscode_deno#1214. Also remove some old compat paths.

Unverified

No user is associated with the committer email.
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 114fe9b into denoland:main Nov 26, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-tasks-object-notation branch November 26, 2024 05:58
bartlomieju pushed a commit that referenced this pull request Nov 28, 2024

Unverified

No user is associated with the committer email.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to detect tasks with the new object notation format
2 participants