fix(info): resolve bare specifier pointing to workspace member #27020
+120
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
changed the title
nathanwhit
commented
Nov 23, 2024
|
updated to use the workspace resolver instead |
marvinhagemeister
approved these changes
Nov 27, 2024
dsherret
approved these changes
Nov 27, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Nov 28, 2024
Fixes #26721 Previously, we were applying only the import map, which would result in `@scope/foo` expanding to (e.g.) `jsr:@scope/foo@1.0.0`. Since that didn't exist it would error and fail to resolve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26721
Previously, we were applying only the import map, which would result in
@scope/fooexpanding to (e.g.)jsr:@scope/foo@1.0.0. Since that didn't exist it would error and fail to resolve.