Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): use primordials in ext/node/polyfills/https.ts #26323

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(ext/node): use primordials in ext/node/polyfills/https.ts #26323

merged 1 commit into from
Oct 21, 2024
+19 −12

Conversation

jiang1997
Copy link
Contributor

Towards #24236

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

marvinhagemeister
marvinhagemeister approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@marvinhagemeister marvinhagemeister merged commit afb33b3 into denoland:main Oct 21, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Oct 25, 2024
@jiang1997 @bartlomieju
fix(ext/node): use primordials in ext/node/polyfills/https.ts (#26323)
9623219 
Towards #24236
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Oct 29, 2024
@bartlomieju
Revert "fix(ext/node): use primordials in `ext/node/polyfills/https.t…
0ea4326 
…s` (denoland#26323)"

This reverts commit afb33b3.
@bartlomieju bartlomieju mentioned this pull request Oct 29, 2024
Merged
bartlomieju added a commit that referenced this pull request Oct 29, 2024
@bartlomieju
Revert "fix(ext/node): use primordials in `ext/node/polyfills/https.t…
46e5ed1 
…s` (#26323)" (#26613)

…s` (#26323)"

This reverts commit afb33b3.

Reverting because it caused a regression -
#26612.

Closes #26612.
bartlomieju added a commit that referenced this pull request Oct 29, 2024
@bartlomieju
Revert "fix(ext/node): use primordials in `ext/node/polyfills/https.t…
a2dacc7 
…s` (#26323)" (#26613)

…s` (#26323)"

This reverts commit afb33b3.

Reverting because it caused a regression -
#26612.

Closes #26612.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiang1997 @CLAassistant @marvinhagemeister