Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno publish --dry-run does not fail on triple-slash directives, while deno publish does. #23774

Open
NfNitLoop opened this issue May 11, 2024 · 0 comments · May be fixed by #23811
Open

deno publish --dry-run does not fail on triple-slash directives, while deno publish does. #23774

NfNitLoop opened this issue May 11, 2024 · 0 comments · May be fixed by #23811
Labels
bug Something isn't working publish Related to "deno publish" subcommand

Comments

@NfNitLoop
Copy link

Version: Deno 1.43.1

deno publish --dry-run completed successfully, but then when I ran deno publish, I got:

Failed to publish @nfnitloop/deno-embedder at 1.2.0: triple slash directives that modify globals (for example, '/// ' or '/// ') are not allowed. Instead instruct the user of your package to specify these directives. file:///embed.ts:1:1

#22835 is another similar issue. It seems like --dry-run is diverging from what publish actually checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working publish Related to "deno publish" subcommand
Projects
None yet
2 participants