Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL.canParse() should throw an error #18893

Closed
zloirock opened this issue Apr 28, 2023 · 1 comment · Fixed by #18896
Closed

URL.canParse() should throw an error #18893

zloirock opened this issue Apr 28, 2023 · 1 comment · Fixed by #18896
Labels
bug Something isn't working good first issue Good for newcomers web related to Web APIs

Comments

@zloirock
Copy link

Version

1.33.0

What is the expected behavior? Why is that the expected behavior?

URL.canParse() // => TypeError: at least 1 argument required, but 0 present.

What do you see instead?

URL.canParse() // => false

Additional information

See the signature https://url.spec.whatwg.org/#url-class

Similar to nodejs/node#47505
@bartlomieju bartlomieju added bug Something isn't working good first issue Good for newcomers web related to Web APIs labels Apr 28, 2023
@petamoriken
Copy link
Contributor

Sorry I missed it, I'll fix it.

@petamoriken petamoriken mentioned this issue Apr 28, 2023
Merged
@zloirock zloirock mentioned this issue Apr 28, 2023
Merged
bartlomieju pushed a commit that referenced this issue Apr 30, 2023
@petamoriken
fix(ext/url): throw TypeError for empty argument (#18896)
74bb09a 
Fixes #18893
levex pushed a commit that referenced this issue May 4, 2023
@petamoriken @levex
fix(ext/url): throw TypeError for empty argument (#18896)
084e7c9 
Fixes #18893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers web related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/url): throw TypeError for empty argument petamoriken/deno
3 participants
@zloirock @petamoriken @bartlomieju