refactor: Plumb through context #2365
Labels
Comments
eddiezane
added
tech-debt 💳
5 tasks
lucasrod16
added a commit
that referenced
this issue
May 15, 2024
## Description refactor context usage in k8s code ## Related Issue Relates to #2365 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
As of opening this issue there are ~50 uses of
context.TODOthroughout the codebase. We should refactor these library functions to accept a context.Links to any relevant code
https://github.com/search?q=repo%3Adefenseunicorns%2Fzarf+NOT+path%3A*test*+context.TODO&type=code&p=1
Additional context
While we could create additional
GetPodsWithContextfunctions it might be better to bite the bullet and make this as part of a breaking change.The text was updated successfully, but these errors were encountered: