Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(refactor): packager warnings to be a proper type or struct #2338

Open
lucasrod16 opened this issue Feb 27, 2024 · 1 comment
Open

chore(refactor): packager warnings to be a proper type or struct #2338

lucasrod16 opened this issue Feb 27, 2024 · 1 comment
Assignees
@lucasrod16
Labels
good first issue 🥇 Good for newcomers tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@lucasrod16
Copy link
Member

Describe what should be investigated or refactored

refactor packager warnings to be a proper type or struct

Links to any relevant code

zarf/src/pkg/packager/common.go

Line 41 in 22f2598

warnings []string

Additional context

#2223 (comment)

cc: @Noxsios
@lucasrod16 lucasrod16 added good first issue 🥇 Good for newcomers tech-debt 💳 Debt that the team has charged and needs to repay labels Feb 27, 2024
@lucasrod16 lucasrod16 mentioned this issue Feb 27, 2024
Merged
5 tasks
@AustinAbro321
Copy link
Contributor

I think we'll probably want to combine at least some of the warnings with the lint / validator. I believe we already have some duplicated logic in the lint code anyway

@lucasrod16 lucasrod16 self-assigned this Mar 19, 2024
@lucasrod16 lucasrod16 changed the title refactor packager warnings to be a proper type or struct chore(refactor): packager warnings to be a proper type or struct Mar 19, 2024
@lucasrod16 lucasrod16 mentioned this issue Mar 19, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasrod16 lucasrod16

Labels
good first issue 🥇 Good for newcomers tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Zarf
Status: In review
Zarf Project Board
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: packager Warnings type defenseunicorns/zarf
2 participants
@AustinAbro321 @lucasrod16