Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: admin ui login theme bug fix #294

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: admin ui login theme bug fix #294

merged 1 commit into from
Dec 20, 2024

Conversation

UnicornChance
Copy link
Contributor

Description

When enabling the admin ui to use a specific type of auth flow, there is a bug that doesnt show the correct client in the login theme. We've never ( add rarely will) use a custom theme for the admin ui however this will be value add with the new authentication configurations.

Testing

  1. Modify the identity-config bundle to be only x509 enable auth flow
  2. deploy identity-config with uds core uds run uds-core-integration-tests
  3. log into Admin UI
  4. change login theme to be Theme
  5. logout
  6. verify that login page has change to the login theme and the title says Admin Account not ${client_security-admin-console}

Screenshot from 2024-12-20 08-52-11

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Sorry, something went wrong.

@UnicornChance UnicornChance self-assigned this Dec 20, 2024
@UnicornChance UnicornChance requested a review from a team as a code owner December 20, 2024 15:52
@UnicornChance UnicornChance merged commit 4988e05 into main Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants