Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uds create silently succeeds on invalid bundle override definitions #558

Closed
zachariahmiller opened this issue Apr 6, 2024 · 0 comments · Fixed by #596
Closed

uds create silently succeeds on invalid bundle override definitions #558

zachariahmiller opened this issue Apr 6, 2024 · 0 comments · Fixed by #596
Assignees
Labels
possible-bug Something may not be working

Comments

@zachariahmiller
Copy link
Contributor

zachariahmiller commented Apr 6, 2024

Environment

Device and OS: m2 MBP
App version: 0.10.3
Kubernetes distro being used: N/A
Other:

Steps to reproduce

  1. Make a bundle like this initial part of the gitlab test bundle
kind: UDSBundle
metadata:
  name: gitlab-test
  description: A UDS bundle for deploying Gitlab and it's dependencies on a development cluster
  # x-release-please-start-version
  version: 16.10.1-uds.1
  # x-release-please-end

packages:
  - name: dev-minio
    repository: ghcr.io/defenseunicorns/packages/uds/dev-minio
    ref: 0.0.2

  - name: dev-namespace
    path: ../
    ref: 0.1.0

  - name: postgres-operator
    repository: ghcr.io/defenseunicorns/packages/uds/postgres-operator
    ref: 1.10.1-uds.4-upstream
    overrides:
      postgres-operator:
        uds-postgres-config:
          variables:
            - name: POSTGRESQL
              description: "Configure postgres using CRs via the uds-postgres-config chart"
              path: postgresql
  1. move the postgres-operator overrides and below back two spaces. (like in screenshot). Note the schema can tell its invalid.
    image

  2. run bundle create

Expected result

bundle creates invalid syntax

Actual Result

bundle create succeeds but the override definition is invalid and doesn't work when subsequently deploying the bundle

Visual Proof (screenshots, videos, text, etc)

I tested multiple times after this issue was brought up to me but the create is embedded inside a longer series of tasks so the output obfuscated. Rest assured it creates.

Severity/Priority

🤷

Additional Context

Add any other context or screenshots about the technical debt here.

@zachariahmiller zachariahmiller added the possible-bug Something may not be working label Apr 6, 2024
@decleaver decleaver self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-bug Something may not be working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants