Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow helm override values to be set via values file #572

Closed
corang opened this issue Apr 17, 2024 · 2 comments · Fixed by #594
Closed

Allow helm override values to be set via values file #572

corang opened this issue Apr 17, 2024 · 2 comments · Fixed by #594
Assignees
@decleaver
Labels
enhancement New feature or request

Comments

@corang
Copy link
Contributor

corang commented Apr 17, 2024

Is your feature request related to a problem? Please describe

When working with large bundles with many helm overrides across many packages the uds-bundle.yaml quickly becomes unwieldy and large from so much extra yaml being under the values in helm overrides. Adopting a pattern similar to how helm already works with values files I think would be beneficial.

Describe the solution you'd like

  • Given a bundle with many values based helmOverrides
  • When a values file is provided and referenced in the uds-bundle.yaml
  • Then those values are passed to the helm chart in that package

Additional context

possible syntax:

  - name: package
    repository: ghcr.io/some/package
    ref: 0.1
    overrides:
      component:
        chart:
          valuesFiles:
          - values-1.yaml
          - values-2.yaml
@corang corang added the enhancement New feature or request label Apr 17, 2024
@UncleGedd
Copy link
Collaborator

UncleGedd commented Apr 17, 2024 •
edited

Appreciate the issue! This is actually something we've been planning on doing for a while but keep getting distracted. We'll make sure it gets in our backlog

@JaseKoonce
Copy link

I would also be super interested in a feature like this. Especially with the namespace override, I am now using a single zarf package multiple times. Having the ability to do this would allow me to not repeat overrides within my uds bundle.

@decleaver decleaver self-assigned this May 7, 2024
@decleaver decleaver mentioned this issue May 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decleaver decleaver

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow helm overrides from valuesfile defenseunicorns/uds-cli
4 participants
@corang @UncleGedd @decleaver @JaseKoonce