Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui) - modal visibility test false positives #523

Open
andrewrisse opened this issue May 15, 2024 · 0 comments
Open

chore(ui) - modal visibility test false positives #523

andrewrisse opened this issue May 15, 2024 · 0 comments
Assignees
Labels
tech-debt 💳 Not a feature, but still necessary

Comments

@andrewrisse
Copy link
Contributor

The modal visibility unit tests are likely giving false positives. The opacity of the modals is set to 0 when they are not open, and we can't test for that in unit tests (modals are still in the DOM, just not visible on page). Either find a way to properly test if they are open or not, or remove the tests.

@andrewrisse andrewrisse added the tech-debt 💳 Not a feature, but still necessary label May 15, 2024
@andrewrisse andrewrisse added this to the v0.8.0 milestone May 15, 2024
@andrewrisse andrewrisse self-assigned this May 15, 2024
@andrewrisse andrewrisse modified the milestones: v0.8.0, v0.9.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt 💳 Not a feature, but still necessary
Projects
None yet
Development

No branches or pull requests

1 participant