Skip to content

Added externs to .npmignore #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

mdhishaamakhtar
Copy link
Contributor

The npm package does not need externs as it is needed only for closure compiler. Added it in .npmignore since bcryptjs overrides global module and process in WebStorm IDE.

Verified

This commit was signed with the committer’s verified signature.
roykho Roy Ho
The npm package does not need externs as it is needed only for closure compiler. Added it in .npmignore since bcryptjs overrides  global module and process in WebStorm IDE.
@mdhishaamakhtar
Copy link
Contributor Author

@dcodeIO Is there any updates for this?

@nowm
Copy link

nowm commented Dec 4, 2020

It would be so nice to see this PR accepted!

@dcodeIO dcodeIO merged commit 7e2e93a into dcodeIO:master Dec 4, 2020
@dcodeIO
Copy link
Owner

dcodeIO commented Dec 4, 2020

Good fix, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants