Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High-level API to unicast signals #374

Closed
zeenix opened this issue Jun 8, 2023 · 0 comments · Fixed by #375
Closed

High-level API to unicast signals #374

zeenix opened this issue Jun 8, 2023 · 0 comments · Fixed by #375
Labels
enhancement New feature or request good first issue Good for newcomers zbus Issues/PRs related to zbus crate

Comments

@zeenix
Copy link
Contributor

zeenix commented Jun 8, 2023

Signals are typically broadcasted so our high-level (dbus_interface-based) API already covers that. However, there are cases where you want to unicast signals (send them only to a specific peer) and it doesn't allow that.

The solution from the top of my head: Add an optional destination to SignalContext and have dbus_interface unicast instead of broadcast, if this is set.
@zeenix zeenix added enhancement New feature or request zbus Issues/PRs related to zbus crate good first issue Good for newcomers labels Jun 8, 2023
zeenix added a commit to zeenix/zbus that referenced this issue Jun 8, 2023
@zeenix
✨ zb,zm: Allow unicast signals through the dbus_interface

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman
GPG key ID: BD1F880DAED1EE78
Verified
Learn about vigilant mode
20ef6bd 
Fixes dbus2#374.
@zeenix zeenix mentioned this issue Jun 8, 2023
Merged
SeaDve pushed a commit to SeaDve/zbus that referenced this issue Aug 6, 2023
@zeenix @SeaDve
✨ zb,zm: Allow unicast signals through the dbus_interface

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman
GPG key ID: BD1F880DAED1EE78
Verified
Learn about vigilant mode
77e4131 
Fixes dbus2#374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers zbus Issues/PRs related to zbus crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ zb,zm: Allow unicast signals through the dbus_interface zeenix/zbus
1 participant
@zeenix