Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.7.latest][MANUAL] Fix listing saved queries #9748

Merged
merged 4 commits into from
Mar 11, 2024
Merged

[Backport 1.7.latest][MANUAL] Fix listing saved queries #9748

merged 4 commits into from
Mar 11, 2024
+51 −2

Conversation

QMalcolm
Copy link
Contributor

Manual backport of 8dffb53^..a131bc5 from #9736

QMalcolm added 4 commits March 11, 2024 09:55
@QMalcolm
Add tests to check that saved queries show in dbt list
025d616
@QMalcolm
Update list task to support saved queries
c48ae1d 
This is built off of @jtcohen6 work in d6e7cda on jerco/fix-9532.
I didn't directly cherry pick because there was more work to do as
well as merge conflicts. That is to say @jtcohen6 should be credited
with some of the work.
@QMalcolm
Update error message when iterating over nodes during list command er…
6aef671 
…rors

This was originally suggested by @jtcohen6 in d6e7cda of jerco/fix-9532.
This commit just makes sure the change gets included because I didn't
cherry-pick that commit into this work.
@QMalcolm
Add changie log for saved query list support
Loading
Loading status checks…
d84cdfe
@QMalcolm QMalcolm requested a review from a team as a code owner March 11, 2024 18:22
@cla-bot cla-bot bot added the cla:yes label Mar 11, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (53d28ee) to head (d84cdfe).

Additional details and impacted files 
@@              Coverage Diff               @@
##           1.7.latest    #9748      +/-   ##
==============================================
- Coverage       86.68%   86.64%   -0.05%     
==============================================
  Files             179      179              
  Lines           26651    26657       +6     
==============================================
- Hits            23103    23097       -6     
- Misses           3548     3560      +12
Flag Coverage Δ
integration 83.48% <100.00%> (-0.11%) ⬇️
unit 64.93% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm QMalcolm merged commit 88bb7a3 into 1.7.latest Mar 11, 2024
62 checks passed
@QMalcolm QMalcolm deleted the backport-9736-to-1.7.latest-manual branch March 11, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martynydbt martynydbt

@graciegoheen graciegoheen

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@QMalcolm @martynydbt