-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README Usage to work with function argument #519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I like that this makes it easier for people to get started.
Just a few small suggestions to tidy it up.
README.rst
Outdated
def function_job(name): | ||
print(f"I am {name}") | ||
schedule.every(10).seconds.do(job, name="Peter Griffin") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schedule.every(10).seconds.do(job, name="Peter Griffin") | |
schedule.every(10).seconds.do(job, name="Peter") |
Let's keep the readme clean of cultural references 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SijmenHuizenga sorry for this but the function name here need to be changed schedule.every(10).seconds.do(job, name="Peter")
to schedule.every(10).seconds.do(function_job, name="Peter")
Co-authored-by: Sijmen <sijmenhuizenga@gmail.com>
Co-authored-by: Sijmen <sijmenhuizenga@gmail.com>
Co-authored-by: Sijmen <sijmenhuizenga@gmail.com>
This PR is about a few changes on the README file, where I added demo usages because people mostly find and wanted to work with function arguments instantly. I created this PR because there are more lazy people like me who will find it useful.
Another example given below is to work with multiple arguments.
Thanks,
@rudSarkar