Fix str of job when there is no __name__ #430
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial functions for example do not have a __name__, so they need the same treatment in __str__ as in __repr__ in order to show a name-like thing.
|
Hi @biggerfisch, thanks a lot for this pr! It takes the small fixes like these that make a library perfect, thank 💪 |
MartinThoma
pushed a commit
to MartinThoma/schedule
that referenced
this pull request
Feb 8, 2021
Partial functions for example do not have a __name__, so they need the same treatment in __str__ as in __repr__ in order to show a name-like thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial functions for example do not have a
__name__, so they need the same treatment in__str__as in__repr__in order to show name-like thing.Also added tests to stop this from happening again.