Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added way to retrieve existing jobs per tags. #419

Merged
merged 4 commits into from
Jan 31, 2021
Merged

Added way to retrieve existing jobs per tags. #419

merged 4 commits into from
Jan 31, 2021

Conversation

Skenvy
Copy link
Contributor

@Skenvy Skenvy commented Jan 21, 2021

In making extensive use of multiple tags on each Job (that define multiple configuration settings that define what that job does, as well as manufactured guids) I've encountered the following need/nice-to-have.

I'd like to be able to use schedule.get_jobs(some_tag) to retrieve an iterable of Job instances which I can then use to log/report on the other tags that have been attached.

If I have functionality that finds Job's that can be periodically removed by comparing against a table of changing guids, but I've used the tags to hold the relevant information that I would like to log to have a human readable history of what Job's were removed, I need a way to get Job's by tags.

The alternative would be to have the Scheduler.clear(...) return the list of jobs that it had removed.

@coveralls
Copy link

coveralls commented Jan 21, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 4e42fe3 on Skenvy:master into 90fb86f on dbader:master.

@SijmenHuizenga
Copy link
Collaborator

Hi! Thanks for this pr. Good idea to add this! Would you be able to add some tests and an example in the docs? Let me know if you need help with any of that.

@Skenvy
Copy link
Contributor Author

Skenvy commented Jan 24, 2021

Added/fixed the test I added for this. Let me know if you need anything else for this PR

@Skenvy
Copy link
Contributor Author

Skenvy commented Jan 27, 2021

Squashed the changes into 1

@SijmenHuizenga SijmenHuizenga merged commit a55c562 into dbader:master Jan 31, 2021
@SijmenHuizenga SijmenHuizenga added this to the 1.1.0 milestone Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants