Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections deprecated in 3.8 #296

Closed
sabato-chris opened this issue Apr 30, 2019 · 2 comments
Closed

Collections deprecated in 3.8 #296

sabato-chris opened this issue Apr 30, 2019 · 2 comments

Comments

@sabato-chris
Copy link

sabato-chris commented Apr 30, 2019

Using the schedule module with my project, and testing with pytest, yields a warning about 3.8 dropping support for collections being called in the way its used.

Running python 3.7.3 with schedule 0.6.0 release.

[csabato@thor-teststand-1 unit_tests]$ python3 -V
Python 3.7.3
[csabato@thor-teststand-1 unit_tests]$ pip install -U schedule
Requirement already up-to-date: schedule in /usr/local/lib/python3.7/site-packages (0.6.0)
[csabato@thor-teststand-1 unit_tests]$

/usr/local/lib/python3.7/site-packages/schedule/init.py:357: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
if not all(isinstance(tag, collections.Hashable) for tag in tags):

gaguirregabiria added a commit to gaguirregabiria/schedule that referenced this issue Aug 1, 2019

Unverified

This user has not yet uploaded their public signing key.
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
gaguirregabiria added a commit to gaguirregabiria/schedule that referenced this issue Aug 2, 2019

Unverified

This user has not yet uploaded their public signing key.
try/except created in the import of collections to select the correct import of Hashable depending on the Python version
dbader added a commit that referenced this issue Aug 2, 2019

Unverified

This user has not yet uploaded their public signing key.
Issue #296:  DeprecationWarning 'collections'
@jneilliii
Copy link

has this merged version not made it's way back to pypi.org yet? I noticed this same warning from an imported module.

@SijmenHuizenga
Copy link
Collaborator

This will be released in the next release, which is almost ready, 🎉, see #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants