Compare property default instance locations by id #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with the rest of the codebase.
The keys used to collect property defaults are mutable hashes, which causes weird hash table problems when they're modified (`#hash` no longer matches even though they have the same `#object_id`). Explained here: https://docs.ruby-lang.org/en/3.3/Hash.html#class-Hash-label-Modifying+an+Active+Hash+Key I think this problem got covered up a bit because it requires more than 8 keys for values to be dropped. `compare_by_identity` fixes things by just using `#object_id` to compare hash keys. It stays consistent after the hash key is mutated. From the [docs][0]: > Note: this requirement does not apply if the Hash uses > `compare_by_identity` since comparison will then rely on the keys' > object id instead of `hash` and `eql?`. Fixes: #179 [0]: https://docs.ruby-lang.org/en/3.3/Hash.html#class-Hash-label-User-Defined+Hash+Keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys used to collect property defaults are mutable hashes, which
causes weird hash table problems when they're modified (
#hashnolonger matches even though they have the same
#object_id).Explained here: https://docs.ruby-lang.org/en/3.3/Hash.html#class-Hash-label-Modifying+an+Active+Hash+Key
I think this problem got covered up a bit because it requires more than
8 keys for values to be dropped.
compare_by_identityfixes things by just using#object_idto comparehash keys. It stays consistent after the hash key is mutated.
From the docs:
Fixes: #179