Fixes #522 by binding requestAnimationFrame to window
#783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w`. This is a no-op in most contexts, but in Firefox content-scripts, this allows `requestAnimationFrame` to function properly.
|
Looks good, will try and find time to test and merge it this week. |
|
Released as v4.2.9 Thanks and sorry for the delay |
|
No worries, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a no-op in most contexts, but in Firefox content-scripts, this allows
requestAnimationFrameto function properly. For more details, see React dealing with the same issue: facebook/react#16606I unfortunately don't have a minimal repo, but can confirm this fixed #522 in my extension.