Migrate away from unittest and adopt pytest #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor fail looks unrelated. LGTM. |
|
@jpurviance Can you rebase this and the other PRs against master? I've fixed the Appveyor issue in #982. |
jpurviance
force-pushed
the
utils-pytest
branch
from
d88c48a
to
38f17ae
Compare
pganssle
approved these changes
Jan 1, 2020
There was a problem hiding this comment.
The content looks good to me, though I'd prefer if the commit message were cleaner.
I skimmed this article and it seems to roughly correspond to my preferred Git style.
I think you'll need to rebase after #990 anyway, so if you don't mind also adjusting the commit message to something like, "Migrate from unittest to pytest for test_utils".
At some point we should probably have a section on a good commit message and clean commit histories in the CONTRIBUTING.rst, since historically I've just manually adjusted the commit histories to my liking as part of the merge.
pganssle
previously requested changes
Jan 1, 2020
Part of a series of commit that is moving the suite.
mariocj89
changed the title
mariocj89
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #976
Pull Request Checklist