Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettz('') result is incorrect per the docs #926

Closed
labrys opened this issue Jun 23, 2019 · 0 comments · Fixed by #1024
Closed

gettz('') result is incorrect per the docs #926

labrys opened this issue Jun 23, 2019 · 0 comments · Fixed by #1024
Labels
bug documentation time zones

Comments

@labrys
Copy link
Contributor

labrys commented Jun 23, 2019

Per the docs:

If no argument or an empty string is passed to gettz, local time is returned:

On Linux it returns None instead of tzlocal().

Related: #925
@labrys labrys changed the title Result of gettz('') is incorrect per the docs gettz('') result is incorrect per the docs Jun 23, 2019
ffe4 added a commit to ffe4/dateutil that referenced this issue Apr 3, 2020
@ffe4
Fix tz.gettz() not returning local time for empty string
f4386ea 
Fixes dateutil#925, dateutil#926

Check for empty string was missing in
@ffe4 ffe4 mentioned this issue Apr 3, 2020
Merged
3 tasks
ffe4 added a commit to ffe4/dateutil that referenced this issue Apr 3, 2020
@ffe4
Fix tz.gettz() not returning local time for empty string
a6f8698 
Fixes dateutil#925, dateutil#926
ffe4 added a commit to ffe4/dateutil that referenced this issue Apr 3, 2020
@ffe4
Fix tz.gettz() not returning local time for empty string
841cc6c 
Fixes dateutil#925, dateutil#926
ffe4 added a commit to ffe4/dateutil that referenced this issue Apr 3, 2020
@ffe4
Fix tz.gettz() not returning local time for empty string
96358e6 
nocache checks the gettz(name) parameter with if not name and tries to get the local time from the TZ environment variable. When the environment variable does not exist, it only checked for name is None, skipping the logic that searches for the local time tzfile when passed an empty string.

Fixes dateutil#925, dateutil#926
ffe4 added a commit to ffe4/dateutil that referenced this issue Apr 5, 2020
@ffe4
Fix tz.gettz() not returning local time for empty string
edb12b6 
nocache checks the gettz(name) parameter with if not name and tries to get the local time from the TZ environment variable. When the environment variable does not exist, it only checked for name is None, skipping the logic that searches for the local time tzfile when passed an empty string.

Fixes dateutil#925, dateutil#926
pganssle pushed a commit to ffe4/dateutil that referenced this issue Apr 24, 2020
@ffe4 @pganssle
Fix tz.gettz() behavior with empty string
4cdf6c7 
The documented behavior of the function is to return a local time zone
when the argument is None or an empty string.

This was working if the TZ environment variable was set, but not working
otherwise.

Fixes dateutil#925, dateutil#926
pganssle pushed a commit to ffe4/dateutil that referenced this issue Apr 24, 2020
@ffe4 @pganssle
Fix tz.gettz() behavior with empty string
bd69e8e 
The documented behavior of the function is to return a local time zone
when the argument is None or an empty string.

This was working if the TZ environment variable was set, but not working
otherwise.

Fixes dateutil#925, dateutil#926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation time zones
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tz.gettz() not returning local time for empty string ffe4/dateutil
2 participants
@pganssle @labrys