New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 2.8.2 release #1143
Prepare 2.8.2 release #1143
Conversation
@pganssle for " If necessary, update the tzdata mirror at https://github.com/dateutil/tzdata" it's just |
IIRC it's a little more involved than that, because you need to update the In any case, it's currently up to date anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we generally use RST syntax for this file, and past tense ("Fixed" rather than "Fix").
I tend to prefer to roughly arrange the news from "most likely to affect people" to "least likely to affect people", within their categories. Obviously this is very subjective, but it may be worth looking at the list and re-arranging it. Other than the stuff I noted I didn't really go through and try and figure out the best order (and obviously not worth spending much time on it).
d56dc06
to
52b6fe4
Compare
Should be ready now for another review @pganssle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I made two minor changes and force pushed an amended cleanup commit.
I think that if you want to trigger the test PyPI CI job, you're going to need to push this to a branch on the dateutil/dateutil repo, not your own fork, because the "manually trigger an update" CI workflow only seems to allow selecting branches, not PRs.
Alternatively pushing a 2.8.2.dev0
tag for this PR would work as well.
Cool ! I land, tag, test the release and then create the release in github. |
After the automatic generation from towncrier, manual fix formatting and remove unrelevant changes.
There seems to be an unrelated failure in appveyor. I'll land and troubleshoot if it happens in master. |
This updates the changelog for the 2.8.1 release.
Relates-to: #1139
versions.
release from https://www.iana.org/time-zones.
tox -e news -- --version <NEXT_VERSION>
template.rst
remains in changelog.d/interesting to anyone consuming the package (e.g. changes to CI) with
a reference to the Github PR.