Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2.8.2 release #1143

Merged
merged 2 commits into from Jul 13, 2021
Merged

Prepare 2.8.2 release #1143

merged 2 commits into from Jul 13, 2021

Conversation

mariocj89
Copy link
Member

@mariocj89 mariocj89 commented Jul 8, 2021

This updates the changelog for the 2.8.1 release.

Relates-to: #1139

  • Update classifiers in setup.cfg to include the latest supported Python
    versions.
  • Update the metadata in zonefile_metadata.json to include the latest tzdata
    release from https://www.iana.org/time-zones.
  • If necessary, update the tzdata mirror at https://github.com/dateutil/tzdata
  • Update NEWS with list of changes:
    • Invoke tox -e news -- --version <NEXT_VERSION>
    • Make sure that only template.rst remains in changelog.d/
    • Manually clean up the new NEWS file.
    • Replace entries in the "Misc" section that are not likely to be
      interesting to anyone consuming the package (e.g. changes to CI) with
      a reference to the Github PR.
  • Commit the changes in git and make a pull request.
  • Follow the "Releasing" steps below

@mariocj89 mariocj89 requested a review from pganssle July 8, 2021 08:41
@mariocj89 mariocj89 self-assigned this Jul 8, 2021
@mariocj89
Copy link
Member Author

mariocj89 commented Jul 8, 2021

@pganssle for " If necessary, update the tzdata mirror at https://github.com/dateutil/tzdata" it's just tox -e update, isnt it?. But is that relevant given that nowadays we have python/tzdata? Is the dateutil/tzdata used at all?

@mariocj89 mariocj89 requested a review from ffe4 July 9, 2021 08:40
@pganssle
Copy link
Member

@pganssle for " If necessary, update the tzdata mirror at https://github.com/dateutil/tzdata" it's just tox -e update, isnt it?. But is that relevant given that nowadays we have python/tzdata? Is the dateutil/tzdata used at all?

IIRC it's a little more involved than that, because you need to update the dateutil/tzdata repo. I think I set that up as a mirror because the old location we were pulling from was not so reliable, but as you say when we switch to using the tzdata PyPI package none of that will be necessary anymore, and I don't know that anyone is using updatezinfo.py right now other than us.

In any case, it's currently up to date anyway.

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we generally use RST syntax for this file, and past tense ("Fixed" rather than "Fix").

I tend to prefer to roughly arrange the news from "most likely to affect people" to "least likely to affect people", within their categories. Obviously this is very subjective, but it may be worth looking at the list and re-arranging it. Other than the stuff I noted I didn't really go through and try and figure out the best order (and obviously not worth spending much time on it).

NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
@mariocj89 mariocj89 force-pushed the pu/2.8.2 branch 2 times, most recently from d56dc06 to 52b6fe4 Compare July 13, 2021 11:29
@mariocj89 mariocj89 requested a review from pganssle July 13, 2021 11:33
@mariocj89
Copy link
Member Author

Should be ready now for another review @pganssle

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I made two minor changes and force pushed an amended cleanup commit.

I think that if you want to trigger the test PyPI CI job, you're going to need to push this to a branch on the dateutil/dateutil repo, not your own fork, because the "manually trigger an update" CI workflow only seems to allow selecting branches, not PRs.

Alternatively pushing a 2.8.2.dev0 tag for this PR would work as well.

@mariocj89
Copy link
Member Author

Cool ! I land, tag, test the release and then create the release in github.

After the automatic generation from towncrier, manual fix formatting and
remove unrelevant changes.
@mariocj89
Copy link
Member Author

There seems to be an unrelated failure in appveyor. I'll land and troubleshoot if it happens in master.

@mariocj89 mariocj89 merged commit 6b03551 into dateutil:master Jul 13, 2021
@mariocj89 mariocj89 deleted the pu/2.8.2 branch July 13, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants