isoparse: Fail with inconsistent time separators #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocj89
force-pushed
the
pu/strict-iso-sep
branch
from
b7e4c5d
to
09dbcd7
Compare
Fail when separators are used inconsistently to split the time porting of a string. Even if more restrictive, we have warned that we were going to fail on invalid cases of ISO formatted strings. This will prevent invalid iso formatted strings from being unexpectedly parsed.
The test was meant to validate `parse_isodate` but was using `parse_isotime` instead. Move the test case to the list validating invalid formats.
mariocj89
force-pushed
the
pu/strict-iso-sep
branch
from
09dbcd7
to
aa62cdc
Compare
pganssle
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fail when separators are used inconsistently to split the time porting
of a string. Even if more restrictive, we have warned that we were going
to fail on invalid cases of ISO formatted strings. This will prevent
invalid iso formatted strings from being unexpectedly parsed.
This Pr also fixes an xfail that was xfailing due to a typo. IIUC, 201202 is a valid ISO time but not a valid iso date, which is what was intended to be tested.
Closes None
Pull Request Checklist