Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constructNow import paths #3734

Merged
merged 1 commit into from Mar 15, 2024
Merged

Conversation

fturmel
Copy link
Member

@fturmel fturmel commented Mar 14, 2024

Introduced by #3731. None of the internal imports go through the root index that re-exports all functions.

Although maybe this is not an issue anymore? The browser tests on GitHub actions are not timing out like they used to (see #3677) since the Vitest 1.3 upgrade.

If this can still cause problems, maybe the root index (and fp index) could be removed from the repo and only generated when publishing to the npm registry?

@kossnocorp
Copy link
Member

Introduced by #3731. None of the internal imports go through the root index that re-exports all functions.

Thank you so much. I used auto imports and missed it 🤦‍♂️ I have to find or write an ESLint plugin to prevent it.

Although maybe this is not an issue anymore? The browser tests on GitHub actions are not timing out like they used to (see #3677) since the Vitest 1.3 upgrade.

I had to fix browser tests, and it seems Vitest was choking because of the number of tests. See: vitest-dev/vitest#5382

If this can still cause problems, maybe the root index (and fp index) could be removed from the repo and only generated when publishing to the npm registry?

That's another way to approach it. I like it even more than linting. I'll look into that!


PS: I tried to contact you via email. Not sure if you saw my messages. Can you please open a GitHub Sponsors account? I love your work so much and would like to support it.

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thank you

@kossnocorp kossnocorp merged commit 3d118e2 into date-fns:main Mar 15, 2024
7 checks passed
@fturmel fturmel deleted the PR/fix-import-paths branch April 1, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants