Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild lock file #3733

Merged
merged 1 commit into from Mar 15, 2024
Merged

Rebuild lock file #3733

merged 1 commit into from Mar 15, 2024

Conversation

fturmel
Copy link
Member

@fturmel fturmel commented Mar 14, 2024

Had to rebuild the lock file to be able to run the unit tests again on macOS. Deleting the "node_modules" directory and re-installing the dependencies was not sufficient.

It appears to be a known bug, see npm/cli#4828

(While we're at it, pnpm would be a nice improvement for the project. It's been very fast and reliable for me over the last few years.)

CleanShot 2024-03-14 at 10 47 52@2x

@kossnocorp
Copy link
Member

Thank you!

(While we're at it, pnpm would be a nice improvement for the project. It's been very fast and reliable for me over the last few years.)

I wouldn't say I like this idea, as it's an additional entry point for the project. I want to keep it simple, as npm is good enough, and such problems happen rarely.

We also use Bun to run timezone tests, so if anything, I would utilize it if not the previous point. I'm open to convincing, though.

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@kossnocorp kossnocorp merged commit f0355f1 into date-fns:main Mar 15, 2024
7 checks passed
@fturmel fturmel deleted the PR/rebuild-lock-file branch April 1, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants