Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for probes if UI port is serving HTTPS #45

Open
nblumhardt opened this issue Oct 30, 2023 · 0 comments
Open

Use HTTPS for probes if UI port is serving HTTPS #45

nblumhardt opened this issue Oct 30, 2023 · 0 comments

Comments

@nblumhardt
Copy link
Member

We have a policy of using end to end TLS for all containers.

I am deploying seq to Kubernetes (AKS cluster + traefik ingress controller). When I switch the UI port to use 443 in the config.yaml like the following

ui:
  containerPort: 443
  service:
    port: 443

The above fails the probes. When I looked at the Helm chart from Seq, I see the port UI is > used in probes but the "scheme" value is not parameterized in helm.
https://github.com/datalust/helm.datalust.co/blob/main/charts/seq/templates/deployment.yaml#L62

I had to manually edit the Kubernetes Seq deployment to set the following in liveness , readiness and startup probe.

scheme: HTTPS

After making the above manual tweak , my pod comes up fine with probes. I was unable to set scheme using the helm and I had to manually tweak the deployment.

My observation:
Anyone who wants to run end to end TLS including the UI port, can't because all probe default to use the HTTP scheme. This do not works with TLS probes. Can you please have a look at the scheme parameter in the helm chart and advise if I have missed something or the scheme in probes needs to be parameterized in the helm chart from Seq.

Originally posted by @Atif-Syed-1 in datalust/seq-tickets#2000

@nblumhardt nblumhardt transferred this issue from datalust/seq-tickets Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant