Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingressClassName and segregate generated Ingress resources #24

Open
pinkfloydx33 opened this issue Feb 10, 2022 · 10 comments
Open

Add ingressClassName and segregate generated Ingress resources #24

pinkfloydx33 opened this issue Feb 10, 2022 · 10 comments

Comments

@pinkfloydx33
Copy link

Please consider adding support for spec.ingressClassName when creating Ingress resources. This field has replaced the deprecated ingress class annotations. There is currently no way to specify this on the generated resources and so must be managed manually. Please add first-class support for this feature.

Additionally, I'd ask that you consider splitting the UI/Ingestion ingresses into separate Ingress resources so that a different value for ingressClassName may be specified for each of them.

Why I need the latter: we run two different ingress controllers in our environment; one is for public traffic and the other is for internal/private network traffic. We expose the Seq UI publicly via the first controller (mainly to support AzureAD) and run the auxiliary ingestion endpoint over the private network only.

I must currently manage the Seq ingresses since I both need the ingressClassName feature and for it to differ between the two ingresses

@KodrAus
Copy link
Member

KodrAus commented Feb 11, 2022

Thanks for the suggestions @pinkfloydx33 👍 So we should be replacing the kubernetes.io/ingress.class annotation with an ingressClassName on the spec itself? That sounds pretty straightforward. Splitting the ingresses also seems reasonable if it doesn't result in too much complexity to continue supporting the case where they're unified. If it does, then managing your own ingress to support your specific environment is probably the right thing to do.

If you (or anybody else) would like to take a stab at this PRs are most welcome, otherwise we'll take a look next time we do a round of work on the chart.

@caiohasouza
Copy link
Contributor

Hi,

I created a PR with this feature (#25), coudl your analyze/aprove please?

Regards

@caiohasouza
Copy link
Contributor

@KodrAus

The PR #25 was approved and merged but i can't use because it don't released a new helm chart version, it's possible create a new version with this feature?

Regards

@KodrAus
Copy link
Member

KodrAus commented Mar 10, 2022

Ah, sorry @caiohasouza I missed the branch name in #25, we should have targeted main rather than a release branch. I'll get that sorted out. We're putting together an initial 2022 release shortly so can roll this into that. I'll let you know when it's all ready to go.

@caiohasouza
Copy link
Contributor

Hi @KodrAus

Cool, do you have some estimate time to release new version? Sorry but i have a necessity to add the ingressClassName to be possible proceed with Kubernetes 1.22 upgrade.

Regards

@KodrAus
Copy link
Member

KodrAus commented Mar 10, 2022

Ah no problems, I'll get a release of the Helm chart together for you now.

@caiohasouza
Copy link
Contributor

Hi @KodrAus

Perfect, thank you so much, i'm waiting.

Regards

@KodrAus
Copy link
Member

KodrAus commented Mar 13, 2022

Thanks for your patience on this one @caiohasouza. We had some trouble getting a build through on Friday we could release, but have one ready to go now. I'll drop another update here once it's all published.

@KodrAus
Copy link
Member

KodrAus commented Mar 14, 2022

Alrighty, we've just published 2022.1.7311-pre that includes these changes. You can use this version of the chart without having to use a preview version of Seq itself by setting the image.repository variable to a specific tag.

@caiohasouza
Copy link
Contributor

Hi @KodrAus

Perfect, thank you so much!

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants