-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consume stream inside explicit txn #15582
Merged
BohuTANG
merged 7 commits into
datafuselabs:main
from
dantengsky:fix-stream-consume-inside-explicit-txn
May 20, 2024
Merged
fix: consume stream inside explicit txn #15582
BohuTANG
merged 7 commits into
datafuselabs:main
from
dantengsky:fix-stream-consume-inside-explicit-txn
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkyFan2002
reviewed
May 20, 2024
SkyFan2002
reviewed
May 20, 2024
tests/sqllogictests/suites/ee/06_ee_stream/06_0002_stream_txn_consume.test
Show resolved
Hide resolved
BohuTANG
reviewed
May 20, 2024
SkyFan2002
approved these changes
May 20, 2024
Consuming stream should respects the semantics of txn
dantengsky
force-pushed
the
fix-stream-consume-inside-explicit-txn
branch
from
May 20, 2024 14:27
551ddd6
to
bed77f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
The consuming (
with consume
) of stream should respect the semantics of transactions: if transaction is aborted, the stream should roll back to its original state.Only the usage of
WITH CONSUME
in queries is allowed. Statements likeINSERT INTO t SELECT * FROM s WITH CONSUME
will fail with errors.Fixes bug:
select ... from stream with consume
not work as expected in non auto commit mode #15581Tests
Type of change
This change is