Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NL: ContainedInPlace should detect multiple types #2962

Open
pradh opened this issue Jul 19, 2023 · 0 comments
Open

NL: ContainedInPlace should detect multiple types #2962

pradh opened this issue Jul 19, 2023 · 0 comments
Labels
nl Issues dealing with the Data Commons NL interface

Comments

@pradh
Copy link
Contributor

pradh commented Jul 19, 2023

With DC place-recognition, [how many people are unemployed in zip codes of washington state] only consumes "washington" leaving out "state". When we recognize place-types, we seem to recognize "state" and leave out "zip codes".

We should loop over multiple place types, and in this case a ContainedInPlace matching the place's type should be ignored.
@pradh pradh added the nl Issues dealing with the Data Commons NL interface label Jul 19, 2023
@pradh pradh mentioned this issue Jul 19, 2023
Merged
pradh added a commit that referenced this issue Jul 19, 2023
@pradh
NL: Switch NL place-detector default to dc (#2963)
844333f 
Also, remove the check-box from frontend. The diffs are pretty clean
(except for an underlying bug -
#2962).

Finally, check for bad-words also from punctuation-removed query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nl Issues dealing with the Data Commons NL interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pradh