Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed select_node_type error #614

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fixed select_node_type error #614

merged 1 commit into from
Apr 12, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Apr 11, 2024

Changes

Calling ws.clusters.select_node_type(local_disk=True, min_memory_gb=16) results in AttributeError: NotAvailableInRegion. This happened because the enum for CloudProviderNodeStatus changed. Updated the enum correctly

Tests

  • make test run locally
  • make fmt applied

@nkvuong nkvuong mentioned this pull request Apr 11, 2024
Merged
2 tasks
@nfx nfx self-requested a review April 12, 2024 09:53
nfx
nfx approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this!

@nfx nfx changed the title fix select_node_type error Fixed select_node_type error Apr 12, 2024
@nfx
Copy link
Contributor

nfx commented Apr 12, 2024 •
edited

ACK on E ImportError: cannot import name 'AzureManagedIdentity' from 'databricks.sdk.service.catalog' in UCX

@nfx nfx enabled auto-merge April 12, 2024 10:01
auto-merge was automatically disabled April 12, 2024 10:35

Head branch was pushed to by a user without write access

@nkvuong nkvuong force-pushed the fix/select-node-type branch 3 times, most recently from 9eb645a to 48aecc1 Compare April 12, 2024 10:42
@mgyucht mgyucht added this pull request to the merge queue Apr 12, 2024
Merged via the queue into databricks:main with commit 855a5e0 Apr 12, 2024
8 of 9 checks passed
mgyucht added a commit that referenced this pull request Apr 12, 2024
@mgyucht
Release v0.25.1
354c694 
Bug fixes:
* Fixed `select_node_type` error ([#614](#614)).
@mgyucht mgyucht mentioned this pull request Apr 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 12, 2024
@mgyucht
Release v0.25.1 (#616)
bf33c14 
Bug fixes:
* Fixed `select_node_type` error
([#614](#614)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nkvuong @nfx @mgyucht