Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Create custom codeql.yml #1114

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

parthban-db
Copy link
Contributor

@parthban-db parthban-db commented Jan 6, 2025

What changes are proposed in this pull request?

With the recent security hardening, we can only use Databricks managed Github runners. This Repo currently uses the general CodeQL setup. Adding a custom codeql.yml to modify the runner group in the current setup.

How is this tested?

This workflow is a test.

@parthban-db parthban-db changed the title Create codeql.yml [Internal] Create custom codeql.yml Jan 6, 2025
@parthban-db parthban-db added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 83db3cb Jan 7, 2025
16 of 19 checks passed
@parthban-db parthban-db deleted the parthban-db-patch-2 branch January 7, 2025 09:28
parthban-db added a commit that referenced this pull request Jan 8, 2025
### Internal Changes

 * Bump staticcheck to 0.5.1 and add go 1.23 test coverage ([#1106](#1106)).
 * Bump x/net, x/crypto dependencies ([#1107](#1107)).
 * Create custom codeql.yml ([#1114](#1114)).
 * Decouple serving and oauth2 package ([#1110](#1110)).
 * Migrate workflows that need write access to use hosted runners ([#1112](#1112)).
 * Move package credentials in config ([#1115](#1115)).
 * Update Queries test ([#1104](#1104)).

### API Changes:

 * Added `NoCompute` field for [apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
 * Added `HasMore` field for [jobs.BaseJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseJob).
 * Added `HasMore` field for [jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
 * Added `PageToken` field for [jobs.GetJobRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#GetJobRequest).
 * Added `HasMore` and `NextPageToken` fields for [jobs.Job](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Job).
 * Added `HasMore` field for [jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
 * Added `RunAs` field for [pipelines.CreatePipeline](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#CreatePipeline).
 * Added `RunAs` field for [pipelines.EditPipeline](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#EditPipeline).
 * Added `AuthorizationDetails` and `EndpointUrl` fields for [serving.DataPlaneInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#DataPlaneInfo).
 * Added .
 * Changed `Update` method for [a.AccountFederationPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#AccountFederationPolicyAPI) account-level service with new required argument order.
 * Changed `Update` method for [a.ServicePrincipalFederationPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ServicePrincipalFederationPolicyAPI) account-level service with new required argument order.
 * Changed `UpdateMask` field for [oauth2.UpdateAccountFederationPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateAccountFederationPolicyRequest) to no longer be required.
 * Changed `UpdateMask` field for [oauth2.UpdateServicePrincipalFederationPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateServicePrincipalFederationPolicyRequest) to no longer be required.
 * Changed `DaysOfWeek` field for [pipelines.RestartWindow](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#RestartWindow) to type [pipelines.DayOfWeekList](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#DayOfWeekList).

OpenAPI SHA: 779817ed8d63031f5ea761fbd25ee84f38feec0d, Date: 2025-01-08
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
### Internal Changes

* Bump staticcheck to 0.5.1 and add go 1.23 test coverage
([#1106](#1106)).
* Bump x/net, x/crypto dependencies
([#1107](#1107)).
* Create custom codeql.yml
([#1114](#1114)).
* Decouple serving and oauth2 package
([#1110](#1110)).
* Migrate workflows that need write access to use hosted runners
([#1112](#1112)).
* Move package credentials in config
([#1115](#1115)).
* Update Queries test
([#1104](#1104)).


### API Changes:

* Added `NoCompute` field for
[apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
* Added `HasMore` field for
[jobs.BaseJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseJob).
* Added `HasMore` field for
[jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
* Added `PageToken` field for
[jobs.GetJobRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#GetJobRequest).
* Added `HasMore` and `NextPageToken` fields for
[jobs.Job](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Job).
* Added `HasMore` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
* Added `RunAs` field for
[pipelines.CreatePipeline](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#CreatePipeline).
* Added `RunAs` field for
[pipelines.EditPipeline](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#EditPipeline).
* Added `AuthorizationDetails` and `EndpointUrl` fields for
[serving.DataPlaneInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#DataPlaneInfo).
* [Breaking] Changed `Update` method for
[a.AccountFederationPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#AccountFederationPolicyAPI)
account-level service with new required argument order.
* [Breaking] Changed `Update` method for
[a.ServicePrincipalFederationPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ServicePrincipalFederationPolicyAPI)
account-level service with new required argument order.
* Changed `UpdateMask` field for
[oauth2.UpdateAccountFederationPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateAccountFederationPolicyRequest)
to no longer be required.
* Changed `UpdateMask` field for
[oauth2.UpdateServicePrincipalFederationPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateServicePrincipalFederationPolicyRequest)
to no longer be required.
* [Breaking] Changed `DaysOfWeek` field for
[pipelines.RestartWindow](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#RestartWindow)
to type
[pipelines.DayOfWeekList](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#DayOfWeekList).

OpenAPI SHA: 779817ed8d63031f5ea761fbd25ee84f38feec0d, Date: 2025-01-08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants