Tweak sequence tokenization #10904
Merged
Tweak sequence tokenization #10904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 13m 3s ⏱️ - 6m 13s Results for commit 097a48a. ± Comparison against base commit f51fa77. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
phofl
reviewed
Feb 8, 2024
| seen = _seen.get() | ||
| tok = None | ||
| except LookupError: | ||
| # This is for debug only, for when normalize_token is called outside of |
There was a problem hiding this comment.
This seems odd, do we really want to keep this?
There was a problem hiding this comment.
It is extremely useful to figure out why tokens have changed when anything goes wrong. I'm already using it in dask/distributed#8185
phofl
approved these changes
Feb 8, 2024
|
thx |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow calling normalize_token() outside of tokenize(). This is useful for debugging purposes.
Additionally, polish some tests in test_tokenize.