Bump minimum click to >=8.1
#10623
Merged
Bump minimum click to >=8.1
#10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2023
pentschev
approved these changes
Nov 9, 2023
jrbourbeau
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Thanks @jacobtomlinson! This seems totally fine to me. Could you also make similar updates to the various mindeps conda env files and the nightly conda package here. Otherwise, this looks good to me
Also, merging main should fix the unrelated test_quantile failures
|
Done thanks @jrbourbeau |
This was referenced Nov 9, 2023
jrbourbeau
approved these changes
Nov 10, 2023
|
Thanks @jrbourbeau for approval and merging! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Dask subproject, I've been running into an issue with registering commands via the
dask.clientrypoint if that command uses aclick.Groupon versions less thanclick==8.1.When running the
daskCLI I see a warning likeAttributeError: 'function' object has no attribute 'command'and the subcommand doesn't get registered.It looks like this was fixed in
click>=8.1. How do folks feel about bumping the minimum version?