refactor the CI + testing setup #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Feb 16, 2023
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
athomas
approved these changes
Feb 16, 2023
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| # Test latest stable, beta, dev channels + last stable release | ||
| # prior to the introduction of the unified `dart` developer tool. | ||
| sdk: [stable, beta, dev, 2.9.3, 2.12.0-29.10.beta] |
There was a problem hiding this comment.
The specific beta case was testing this branch:
https://github.com/dart-lang/setup-dart/blob/main/setup.sh#L27
If we have no case were we test "detect channel from version anymore" we lose coverage.
There was a problem hiding this comment.
Gotcha - I'll update this PR to test inferring the channel from the sdk param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor the CI + testing setup:
test- and additional ones for the flavor and architecture params