Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically choose the correct architecture #59

Closed
nex3 opened this issue Aug 3, 2022 · 4 comments · Fixed by #77
Closed

Automatically choose the correct architecture #59

nex3 opened this issue Aug 3, 2022 · 4 comments · Fixed by #77
Labels
type-enhancement A request for a change that isn't a bug

Comments

@nex3
Copy link
Member

nex3 commented Aug 3, 2022

Currently, this action always defaults to installing the x64 Dart binaries, even when running on architectures that aren't compatible with x64 (such as MacOS ARM). It would be nice if it instead defaulted to checking the current architecture and installing the matching binary.
nex3 added a commit to sass/dart-sass-embedded that referenced this issue Aug 3, 2022
@nex3
Specify architectures when installing Dart
9c82bc7 
Workaround for dart-lang/setup-dart#59
@nex3 nex3 mentioned this issue Aug 3, 2022
Merged
nex3 added a commit to sass/dart-sass-embedded that referenced this issue Aug 3, 2022
@nex3
Specify architectures when installing Dart (#103)
9bc9f49 
Workaround for dart-lang/setup-dart#59
joshpeterson30489 added a commit to joshpeterson30489/embedded-dart-sass-development that referenced this issue Sep 30, 2022
@joshpeterson30489
Specify architectures when installing Dart (#103)
f81c523 
Workaround for dart-lang/setup-dart#59
@devoncarew devoncarew mentioned this issue Oct 17, 2022
Open
6 tasks
@devoncarew devoncarew added the type-enhancement A request for a change that isn't a bug label Nov 4, 2022
@devoncarew devoncarew mentioned this issue Feb 17, 2023
Closed
@devoncarew devoncarew mentioned this issue Mar 1, 2023
Merged
nex3 added a commit to sass/dart-sass that referenced this issue Mar 6, 2023
@nex3
Remove workaround for dart-lang/setup-dart#59
9feb5ee
nex3 added a commit to sass/dart-sass-embedded that referenced this issue Mar 6, 2023
@nex3
Remove workaround for dart-lang/setup-dart#59
9f214a5
nex3 added a commit to sass/dart-sass that referenced this issue Mar 6, 2023
@nex3
Remove workaround for dart-lang/setup-dart#59 (#1904)
434f2b9
nex3 added a commit to sass/dart-sass-embedded that referenced this issue Mar 6, 2023
@nex3
Remove workaround for dart-lang/setup-dart#59 (#151)
7d38d42
@nex3
Copy link
Member Author

nex3 commented Mar 10, 2023

It looks like this is still an issue, at least for Mac OS ARM machines: https://github.com/sass/dart-sass/actions/runs/4388953095/jobs/7686128912

jathak added a commit to sass/dart-sass that referenced this issue Mar 10, 2023
@jathak
Revert "Remove workaround for dart-lang/setup-dart#59 (#1904)"
1e7106b 
This reverts commit 434f2b9.
@devoncarew
Copy link
Member

Are you using the published version of setup-dart or the latest from head?

@devoncarew
Copy link
Member

We plan to publish ~next week (after a bit of burn-in time). #79 has info on how to use the version from head.

@nex3
Copy link
Member Author

nex3 commented Mar 10, 2023

We're using the @v1 tag. We'll probably wait to update until the stable version is published.

jathak added a commit to sass/dart-sass that referenced this issue Mar 10, 2023
@jathak
Fix macOS arm64 build and release a new version (#1906)
d0ca8e0 
* Revert "Remove workaround for dart-lang/setup-dart#59 (#1904)"

This reverts commit 434f2b9.

* Bump version
jathak added a commit to sass/dart-sass-embedded that referenced this issue Mar 11, 2023
@jathak
Revert "Remove workaround for dart-lang/setup-dart#59 (#151)"
4db33bb 
This reverts commit 7d38d42.
jathak added a commit to sass/dart-sass-embedded that referenced this issue Mar 11, 2023
@jathak
Revert "Remove workaround for dart-lang/setup-dart#59 (#151)" (#153)
c6752b5 
This reverts commit 7d38d42.
@snyk-bot snyk-bot mentioned this issue Mar 22, 2023
Closed
@brianthiely brianthiely mentioned this issue Apr 1, 2023
Open
@snyk-bot snyk-bot mentioned this issue Apr 1, 2023
Open
@aiswalprince07 aiswalprince07 mentioned this issue Apr 1, 2023
Open
This was referenced Apr 1, 2023
Merged
Open
Closed
Open
Open
@jydmyk jydmyk mentioned this issue Jun 5, 2023
Open
@AngelovanOsch1 AngelovanOsch1 mentioned this issue Jun 5, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jun 5, 2023
Open
@russellcs russellcs mentioned this issue Jun 6, 2023
Open
@SuperSuperDev SuperSuperDev mentioned this issue Jun 6, 2023
Open
@JaRoD41 JaRoD41 mentioned this issue Jun 7, 2023
Closed
@snyk-bot snyk-bot mentioned this issue Jun 7, 2023
Closed
@pawaramit1423 pawaramit1423 mentioned this issue Jun 8, 2023
Closed
@gpq8l8s gpq8l8s mentioned this issue Jun 9, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jun 12, 2023
Open
@gatolife-creator gatolife-creator mentioned this issue Jun 15, 2023
Open
@leonardoadame leonardoadame mentioned this issue Jun 15, 2023
Merged
@ariel131998 ariel131998 mentioned this issue Jun 16, 2023
Open
@magarteem magarteem mentioned this issue Jun 19, 2023
Open
@Fenny Fenny mentioned this issue Jun 22, 2023
Open
@kiraanikeev kiraanikeev mentioned this issue Jun 22, 2023
Open
@fabcocco fabcocco mentioned this issue Jun 24, 2023
Closed
@dovletovOrun dovletovOrun mentioned this issue Jun 26, 2023
Open
@dogukankutluay dogukankutluay mentioned this issue Jun 27, 2023
Open
@laconi51 laconi51 mentioned this issue Jun 27, 2023
Open
@nek0ill nek0ill mentioned this issue Jun 27, 2023
Open
@LeonTheDev-io LeonTheDev-io mentioned this issue Jun 28, 2023
Open
@kessio kessio mentioned this issue Jun 28, 2023
Open
@fabcocco fabcocco mentioned this issue Jun 28, 2023
Merged
@pSakowski pSakowski mentioned this issue Jun 28, 2023
Open
@GavinLin512 GavinLin512 mentioned this issue Jun 28, 2023
Open
@DennisPirotta DennisPirotta mentioned this issue Jun 28, 2023
Open
@maieutiquer maieutiquer mentioned this issue Jun 28, 2023
Open
@San0077 San0077 mentioned this issue Jun 28, 2023
Open
@leonardoadame leonardoadame mentioned this issue Jun 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
2 participants
@nex3 @devoncarew