Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the caching of the downloaded sdks #2

Open
mit-mit opened this issue Dec 11, 2020 · 6 comments
Open

Improve the caching of the downloaded sdks #2

mit-mit opened this issue Dec 11, 2020 · 6 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@mit-mit
Copy link
Member

mit-mit commented Dec 11, 2020

From the review of #1 by @athomas:

Perhaps we should download this into ${RUNNER_TOOL_CACHE}/dart//

That would enable checking if the version is in the cache later. It would mean we'd have to resolve latest to a specific version though.

@mit-mit mit-mit mentioned this issue Dec 11, 2020
@kevmoo
Copy link
Member

kevmoo commented Dec 14, 2020

We could cache the etag, too – then use a HEAD request to compare?

Starting to get a bit complex for a bash script, though...

@kevmoo
Copy link
Member

kevmoo commented Dec 14, 2020

Ooo! See https://stackoverflow.com/a/12475760/39827

curl --dump-header header_dump www.google.no
 curl -I -v --header 'If-None-Match: "1d30-4c993ec28581d"' http://httpd.apache.org

@mit-mit mit-mit added the type-enhancement A request for a change that isn't a bug label Mar 24, 2021
@natebosch
Copy link
Member

This could mitigate some of the flakiness we are seeing downloading the SDK.

@mit-mit
Copy link
Member Author

mit-mit commented Apr 19, 2022

Someone wants to take a stab at that in a PR? Then we can commit that, and try out the action pinned to that commit in some repo and see if that helps with flakiness?

@serverwentdown
Copy link

serverwentdown commented Aug 1, 2022

This has already been done. The current script uses RUNNER_TOOL_CACHE

@devoncarew
Copy link
Member

From some investigation, I don't believe this action is using caching. We are writing the downloaded and uncompressed sdk into $RUNNER_TOOL_CACHE, but I don't believe that directory implies any automatic caching. I believe it's just the path to a directory with many pre-installed sdks for various languages (pre-installed for the specific image).

@devoncarew devoncarew changed the title Consider moving downloads into ${RUNNER_TOOL_CACHE}/dart/ Improve the caching of the downloaded sdks Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants