Work list for deprecation of UnmodifiableUint8ListView and friends
#53785
Assignees
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
library-typed-data
Comments
rakudrama
added
area-core-library
copybara-service bot
pushed a commit
that referenced
this issue
Oct 20, 2023
This is the first of several steps to remove the unmodifiable views for typed data classes. The end goal is that dart2js has only one class implementing `Uint8List` so that `Uint8List` accesses can always be compiled down to JavaScript code that directly uses indexed property accesses (`a[i]`). This first step deprecates the unmodifiable view classes to help prevent their use in new code, and adds `asUnmodifiableView()` methods as a replacement for the small number of places that use the classes. The next steps (see #53785) are to remove uses of the unmodifiable view classes from the SDK. Once this is complete the classes themselves can be removed. TEST=ci Issue: #53218 Issue: #53785 Change-Id: I04d4feb0d9f1619e6eee65236e559f5e6adf2661 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/321922 Reviewed-by: Nicholas Shahan <nshahan@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com> Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 23, 2023
This reverts commit b657773. Reason for revert: blocking Dart SDK -> Engine roll (flutter/flutter#137054) Original change's description: > [typed_data] Deprecate UnmodifiableUint8ListView and friends > > This is the first of several steps to remove the unmodifiable views for typed data classes. The end goal is that dart2js has only one class implementing `Uint8List` so that `Uint8List` accesses can always be compiled down to JavaScript code that directly uses indexed property accesses (`a[i]`). > > This first step deprecates the unmodifiable view classes to help prevent their use in new code, and adds `asUnmodifiableView()` methods as a replacement for the small number of places that use the classes. > > The next steps (see #53785) are to remove uses of the unmodifiable view classes from the SDK. Once this is complete the classes themselves can be removed. > > TEST=ci > > Issue: #53218 > Issue: #53785 > > Change-Id: I04d4feb0d9f1619e6eee65236e559f5e6adf2661 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/321922 > Reviewed-by: Nicholas Shahan <nshahan@google.com> > Reviewed-by: Lasse Nielsen <lrn@google.com> > Commit-Queue: Stephen Adams <sra@google.com> > Reviewed-by: Alexander Markov <alexmarkov@google.com> > Reviewed-by: Martin Kustermann <kustermann@google.com> > Reviewed-by: Ömer Ağacan <omersa@google.com> Issue: #53218 Issue: #53785 Change-Id: I0bb042269f9ff8e5cd69619cf97b60c79ea98cbf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331680 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Derek Xu <derekx@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 23, 2023
This reverts commit 4918d3e. `@Deprecated` annotations have been commented out. CoreLibraryReviewExempt: reviewed as https://dart-review.googlesource.com/c/sdk/+/321922 TEST=ci Bug: #53785 Change-Id: I3239251c2aba5f188aa947f0ff0208271d6be5cc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331741 Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com> Reviewed-by: Derek Xu <derekx@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 25, 2023
CoreLibraryReviewExempt: Reviewed in https://dart-review.googlesource.com/c/sdk/+/321922 Bug: #53785 Change-Id: I23a064e76a4b359e804f41676b3b775dd02ea183 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331723 Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 27, 2023
This reverts commit b4bae46. Reason for revert: Flutter plugin contains use of deprecated method. Original change's description: > [typed_data] Deprecate unmodifiable views > > CoreLibraryReviewExempt: Reviewed in https://dart-review.googlesource.com/c/sdk/+/321922 > Bug: #53785 > Change-Id: I23a064e76a4b359e804f41676b3b775dd02ea183 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331723 > Commit-Queue: Stephen Adams <sra@google.com> > Reviewed-by: Lasse Nielsen <lrn@google.com> Bug: #53785 Change-Id: I01998a3d74681ef2d8c804f59a82d51a2e4290e7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332580 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Stephen Adams <sra@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 27, 2023
Update TypedDataPoly benchmark to use `asUnmodifiableView()` instead of the deprecated typed data view constructors. Bug: #53785 Change-Id: I02381e3db37f44b01da25d7cbd728b525ff4899e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332161 Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Stephen Adams <sra@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Nov 2, 2023
…constructor Issue: #53785 Change-Id: I205492adcec6432f5503cbf9f015a6ac2e9d6f5c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332165 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Feb 6, 2024
This change, for Dart 3.4, deprecates the unmodifiable typed data constructors. Users of these constructors can upgrade the use of the constructors to instance method `asUnmodifiableView()`, or pin to Dart 3.3. See #53785 for context. CoreLibraryReviewExempt: Reviewed in https://dart-review.googlesource.com/c/sdk/+/321922 Issue: #53785 Change-Id: Icd52f2b6cd05cf3a328c82c197ef44d0b340b171 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332581 Reviewed-by: Lasse Nielsen <lrn@google.com> Commit-Queue: Stephen Adams <sra@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Jun 13, 2024
In most cases, the (now removed) SDK class was patched so that the constructor redirected to a platform-specific implementation of the unmodifiable view. Uses of the SDK class in the platform code could be rewritten to the more direct use of the implementation class. The big +/- file changes are from moving the implementation classes from the patch file (typed_data_patch.dart), where they are no longer needed, to the internal file (typed_data.dart). TEST=ci Bug: #53785 Change-Id: Iaa7370de25b7fc2d26b24f7733c2892868e593cb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370661 Reviewed-by: Ömer Ağacan <omersa@google.com> Reviewed-by: Lasse Nielsen <lrn@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Brian Quinlan <bquinlan@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Jul 10, 2024
- Add SSA HArrayFlags{Check,Get,Set} instructions to check for
fixed-length and unmodifiable JSArray and JavaScript typed data
instances.
- Add optimizations to remove redundant checks.
- Added HOutputConstrained interface for instructions that must have
the input and output in the same JavaScript variable. This
generalizes some code generation logic already applied to HCheck.
Bug: #53785
Change-Id: I61750dd03aa3a964eed3bc76e1656c5f60f77109
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372002
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
jjanku
added a commit
to crocs-muni/meesign-client
that referenced
this issue
Oct 13, 2024
These were removed with Dart 3.5, see dart-lang/sdk#53785. To fix it, use asUnmodifiableView() in apdu.dart and upgrade packages that used the deprecated api, namely archive and win32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For 3.3 release:
UnmodifiableUint8ListViewand friends #53218asUnmodifiableViewmethod that use the deprecated classes.UnmodifiableUint8ListViewetc cannot be deprecated for this release as Flutter needs a stable release with the new API and without deprecations.For 3.4 release:
asUnmodifiableViewmethods will be changed to use to the private implementation classes of theUnmodifiableXXXViewclasses. Some of this can be done in 3.3UnmodifiableXXXViewclasses in terms ofasUnmodifiableView, remove the patches for these deprecated classes.For 3.5 release:
dart2js optimization work (spanning 3.4, 3.5 and beyond). These are all large tasks.
The text was updated successfully, but these errors were encountered: