Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dart-lang/sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.7.1
Choose a base ref
...
head repository: dart-lang/sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.7.2
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Mar 5, 2025

  1. [stable] [deps] Roll jsshell & firefox to newer version

    Issue:
      Firefox performs more strict validation when enabling the `js-string`
      builtin. Namely it requires the wasm array to `fromCharCodeArray` to be
      nullable (as per-spec), where D8 is more lenient and allows non-nullable
      wasm array just fine.
    
      In principle it shouldn't be nullable as passing a null will make the
      function trap at runtime. But the spec says it should be nullable and if
      it isn't, Firefox will fail validation.
    
      Soon Chrome will start enforcing this.
    
    Fix:
      Import the function with a nullable wasm array type as parameter.
    
    Why Cherry-pick:
      Apps compiled with dart2wasm will no longer work with newer Chrome
      (once they roll out stricter validation).
    
    Risk: Low
    
    Issue #59899
    
    Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/404300
    Change-Id: Icde5eccfdc2cf1e4666be6c670105b896b1a19a7
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413440
    Commit-Queue: Martin Kustermann <kustermann@google.com>
    Reviewed-by: Alexander Thomas <athom@google.com>
    mkustermann authored and Commit Queue committed Mar 5, 2025
    Copy the full SHA
    5a75c51 View commit details

Commits on Mar 11, 2025

  1. Version 3.7.2

    Change-Id: I6b935ab445657efddc9fe3eac8f863035be6f00c
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414667
    Auto-Submit: Alexander Thomas <athom@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    Commit-Queue: Martin Kustermann <kustermann@google.com>
    athomas authored and Commit Queue committed Mar 11, 2025
    Copy the full SHA
    9594995 View commit details
Loading