-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: dart-lang/sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.7.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: dart-lang/sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.7.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 130 files changed
- 4 contributors
Commits on Feb 13, 2025
-
Issue description: The DevTools network profiler is broken for users on stable due to timestamp logic that can cause a race condition, resulting in missing data in the network profiler. What is the fix: Use previous HTTP profile timestamps instead of DateTime.now() when requesting HTTP profiles. This will eliminate the possibility of a race condition for users with network latency. Why cherry-pick: Many users are broken with the current behavior. We have received many reports of this breakage and a fix is required to unblock user workflows flutter/devtools#8380. Risk: Low. The network tool is already broken on stable for many users so this fix will only improve the current state. Issue link(s): flutter/devtools#8888 Cherry-pick: flutter/devtools#8888 Change-Id: Ib9c643c8116680f6746cc34b7b475c595577bf08 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409564 Reviewed-by: Elliott Brooks <elliottbrooks@google.com> Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Configuration menu - View commit details
-
Copy full SHA for 5299249 - Browse repository at this point
Copy the full SHA 5299249View commit details
Commits on Feb 16, 2025
-
[stable][ddc] Correctly extend type parameters for factory constructors.
Issue description: There was a bug in DDC where generics in factory constructors caused compile time errors. This prevents people from debugging their code on the web when it includes this pattern. What is the fix: Fix DDC's handling of type environments in factory constructors. Why cherry-pick: As seen in the Flutter issue linked to below, many people have expressed that this issue is blocking them. People cannot develop on the web if their code includes this pattern. Risk: The risk here is low, this is an isolated fix to DDC type parameters. It has been tested in internal environments for 2 weeks now and no issues have been discovered. Issue: flutter/flutter#160338 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/406344 Change-Id: If32d2343f4ca2d7c9334dfb868fc152a4f431b97 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410164 Commit-Queue: Nate Biggs <natebiggs@google.com> Reviewed-by: Slava Egorov <vegorov@google.com>
Configuration menu - View commit details
-
Copy full SHA for 163c9a3 - Browse repository at this point
Copy the full SHA 163c9a3View commit details
Commits on Feb 19, 2025
-
[stable][cfe] Issue 60121: Fix bug with isWildcard flag for formals.
Issue description: Users are finding that their debug variables are evaluated to the wrong values and it's due to wildcard variables being included, but being unable to be evaluated. Wildcard variables shouldn't be able to be evaluated in the first place. What is the fix: Correctly propagate the `isWildcard` flag in the CFE to formal parameters. The VM uses this flag to determine if the variable can be excluded from debugging evaluation. The flag is now set correctly with the fix and won't appear in VM debug. Why cherry-pick: This is causing debug variables to be evaluated incorrectly because wildcard variables are appearing in the debug panel of variables and shouldn't be. Risk: Low, fixes wildcard variables that are formal parameters and touches no other code. This is code that should've been in the feature from the start. Issue link(s): #60121 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/410161 Change-Id: Ie7aa3561183e6e326d65c09165a132d6bb3e72a2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410640 Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Configuration menu - View commit details
-
Copy full SHA for 6b10c38 - Browse repository at this point
Copy the full SHA 6b10c38View commit details
Commits on Feb 25, 2025
-
Change-Id: I06a39b1faaf5e4f5e0c0d19ba9be28bb3e4cd5d2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412142 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Configuration menu - View commit details
-
Copy full SHA for dcddfab - Browse repository at this point
Copy the full SHA dcddfabView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 3.7.0...3.7.1