Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-publish check for DevTools extension validation #4026

Closed
kenzieschmoll opened this issue Sep 25, 2023 · 2 comments · Fixed by #4135
Closed

Add a pre-publish check for DevTools extension validation #4026

kenzieschmoll opened this issue Sep 25, 2023 · 2 comments · Fixed by #4135
Labels
type-enhancement A request for a change that isn't a bug

Comments

@kenzieschmoll
Copy link

This is a feature originally requested and discussed here: rrousselGit/provider#832 (comment).

This check would fail on pub publish --dry-run if a DevTools extension is expected and none was found.

@rrousselGit
Copy link

It'd be cool if the check could not only very that the build folder exists, but also check that the build output is more recent than the source files.

When thinking about this problem, I realized that gitignored files would still be present on the computer at the publish step. So if publishing locally instead of in a CI, the check could incorrectly pass.

@sigurdm
Copy link
Contributor

sigurdm commented Feb 8, 2024

When thinking about this problem, I realized that gitignored files would still be present on the computer at the publish step. So if publishing locally instead of in a CI, the check could incorrectly pass.

I think we can get around this problem by only considering files not gitignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants