Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambigious dartdoc version value when unspecified. #1343

Merged
merged 1 commit into from Feb 12, 2024
Merged

Fix ambigious dartdoc version value when unspecified. #1343

merged 1 commit into from Feb 12, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 12, 2024

Fixes #1338

@isoos
Copy link
Collaborator Author

isoos commented Feb 12, 2024

Note: let's also deploy the fix after merging, to unblock CIs.

@isoos isoos mentioned this pull request Feb 12, 2024
Closed
@isoos
Copy link
Collaborator Author

isoos commented Feb 12, 2024

Another note: this does not affect pub-dev or the end2end tests because we have always pinned the dartdoc version there to a specific value, that is the reason it got undetected.

@sigurdm sigurdm merged commit d65be4a into dart-lang:master Feb 12, 2024
5 checks passed
@sigurdm
Copy link
Contributor

sigurdm commented Feb 12, 2024

Published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Provide documentation" step fails with 'Could not find an option named "sanitize-html".'
2 participants
@isoos @sigurdm