Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for removal of analysis_options_user.yaml from Flutter #1329

Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 6, 2024

This file no longer exists after flutter/flutter#138261 and is generally no longer supported.

Also update nearby code with expanded comments and avoiding the non-null assertions.

@parlough parlough changed the title Account for removal of analysis_options_user.yaml in Flutter Account for removal of analysis_options_user.yaml from Flutter Feb 6, 2024
Copy link
Collaborator

@isoos isoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an update for the golden files:

  • rm test/goldens/end2end/*json*
  • dart test test/end2end_test.dart

@isoos
Copy link
Collaborator

isoos commented Feb 6, 2024

I think you may have deleted all the files and not just *json*, which needs a full re-run if you change SDKs (as the dependencies will change).

@parlough parlough requested a review from isoos February 6, 2024 18:35
@parlough
Copy link
Member Author

parlough commented Feb 6, 2024

Thanks for the help with the goldens! I think I was only considering my Dart setup and needed to use a matching Flutter build.

lib/src/analysis_options.dart Outdated Show resolved Hide resolved
@isoos isoos merged commit f41a55d into dart-lang:master Feb 7, 2024
5 checks passed
@parlough parlough deleted the misc/analysis-options-user-file-removal branch February 8, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants